[pytorch] Allows load libtroch from pip installation package #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic87302a880564027bed1f213088baac1ee543d9e
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
============================================
- Coverage 72.08% 70.85% -1.24%
- Complexity 5126 5395 +269
============================================
Files 473 503 +30
Lines 21970 23597 +1627
Branches 2351 2567 +216
============================================
+ Hits 15838 16719 +881
- Misses 4925 5598 +673
- Partials 1207 1280 +73
Continue to review full report at Codecov.
|
|
Have you tested this set up? Does the jobs hang? |
lanking520
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic87302a880564027bed1f213088baac1ee543d9e
Description
the default PyTorch pip package contains both cpu and gpu native binaries. Currently DJL can only load cpu/gpu only pip package:
This PR allows DJL to load libtorch from default pip package on CPU machine. However load on GPU machine will still fail due to missing
libtorch_cuda_cpp.sofile in the default pip pacakge.